Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the build release workflow #81

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Dec 3, 2020

It looks like the TypeScript project wasn't and currently isn't being built before being published. This is resulting in the module not working.

This change runs the build step before publishing the module.

Fixes #80

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from bcoe December 3, 2020 01:13
@grant grant self-assigned this Dec 3, 2020
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. label Dec 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@grant grant requested a review from grayside December 3, 2020 02:31
@grant grant added the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 03ac5be into master Dec 3, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2020
@grant grant deleted the grant_release_build branch December 3, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure to compile TS before Publishing
2 participants